C#: Also syntheize calls to inherited ToString.
#18508
Conversation
…ToString call being synthesized.
michaelnebel
force-pushed
the
csharp/implicitinheritedtostring
branch
from
6293862 to
bae29ae
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- csharp/ql/test/library-tests/implicittostring/implicitToString.expected: Language not supported
- csharp/ql/test/library-tests/implicittostring/implicitToString.ql: Language not supported
- csharp/ql/test/query-tests/Nullness/Implications.expected: Language not supported
Comments suppressed due to low confidence (2)
csharp/ql/test/library-tests/implicittostring/implicitToString.cs:49
- Ensure that the behavior of the inherited
ToStringmethod inContainer2is covered by the test cases.
y = "Hello" + container2; // Implicit Container.ToString call.
csharp/ql/test/library-tests/implicittostring/implicitToString.cs:52
- Ensure that the behavior of the inherited
ToStringmethod inContainer3is covered by the test cases.
y = "Hello" + container3; // Implicit Object.ToString call.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
| .GetMembers() | ||
| .OfType<IMethodSymbol>() | ||
| .Where(method => | ||
| method.GetName() == "ToString" && | ||
| method.Parameters.Length == 0 | ||
| ) | ||
| .FirstOrDefault(); | ||
|
|
||
| return toString ?? GetToStringMethod(type.BaseType); |
There was a problem hiding this comment.
It's odd that we have no helper for getting the base types already. Maybe adding this to SymbolExtensions would make sense.
There was a problem hiding this comment.
It looks like the base types are used in all sorts of different ways and I didn't find any overlapping use cases for recursively going through the type hierarchy to find a method.
No description provided.